Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: concurrency safety #1445

Merged
merged 1 commit into from
May 30, 2023
Merged

nsqd: concurrency safety #1445

merged 1 commit into from
May 30, 2023

Conversation

gueFDF
Copy link
Contributor

@gueFDF gueFDF commented Apr 26, 2023

Should be placed in the critical section for access.

@mreiferson
Copy link
Member

Thanks for this. Can you please update this PR to just fix the issue you found in cfbd287? We can discuss 34f2e70 separately.

@mreiferson mreiferson added the bug label May 7, 2023
@mreiferson mreiferson changed the title fix(nsqd):concurrency safety nsqd: concurrency safety May 7, 2023
@gueFDF
Copy link
Contributor Author

gueFDF commented May 8, 2023

谢谢你。您能否更新此 PR 以仅修复您在cfbd287中发现的问题？我们可以单独讨论34f2e70。

Ok I did that.

@mreiferson mreiferson merged commit 96c8f19 into nsqio:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gueFDF @mreiferson