Merge pull request #1441 from ploxiln/spreadwriter_flush_empty

SpreadWriter: fix flush panic with zero writes
nsqio · Mar 6, 2023 · 1362af1 · 1362af1
2 parents b28153e + af67175
commit 1362af1
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/internal/writers/spread_writer.go b/internal/writers/spread_writer.go
@@ -29,6 +29,14 @@ func (s *SpreadWriter) Write(p []byte) (int, error) {
 }
 
 func (s *SpreadWriter) Flush() {
+	if len(s.buf) == 0 {
+		// nothing to write, just wait
+		select {
+		case <-time.After(s.interval):
+		case <-s.exitCh:
+		}
+		return
+	}
 	sleep := s.interval / time.Duration(len(s.buf))
 	ticker := time.NewTicker(sleep)
 	for _, b := range s.buf {