feat(webpack): Support incremental builds via buildLibsFromSource #25060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 17432a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
requested changes
May 23, 2024
packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts
Outdated
Show resolved
Hide resolved
ndcunningham
force-pushed
the
feat/webpack-plugin-build-lib-from-source-option
branch
from
975d0f2 to
b3fbc96
Compare
ndcunningham
force-pushed
the
feat/webpack-plugin-build-lib-from-source-option
branch
from
b3fbc96 to
17432a9
Compare
ndcunningham
added a commit
that referenced
this pull request
May 28, 2024
…5060) This PR adds the ability for incremental builds when using the Webpack Plugin. Instead of using the source library directly, you can now utilize the output folder by utilizing the `buildLibsFromSource` option within your webpack.config file, through `NxAppWebpackPlugin`. This means that instead of accessing `mylib/src/index.ts`, it will access `dist/mylib/index.js`. This directly aligns with incremental builds as it ensures that the build process only recompiles the source doe that has been modified since the last build.
FrozenPandaz
pushed a commit
that referenced
this pull request
May 28, 2024
…5060) This PR adds the ability for incremental builds when using the Webpack Plugin. Instead of using the source library directly, you can now utilize the output folder by utilizing the `buildLibsFromSource` option within your webpack.config file, through `NxAppWebpackPlugin`. This means that instead of accessing `mylib/src/index.ts`, it will access `dist/mylib/index.js`. This directly aligns with incremental builds as it ensures that the build process only recompiles the source doe that has been modified since the last build. (cherry picked from commit 6292055)
therk
reviewed
Jun 3, 2024
There was a problem hiding this comment.
@ndcunningham what is the easiest way to set buildLibFromSource to false without creating a custom webpack.config.js file? This change is causing failures form my project when used with cypress component tests library that is referencing Storybook Library module in the project.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for incremental builds when using the Webpack Plugin.
Instead of using the source library directly, you can now utilize the output folder by utilizing the
buildLibsFromSourceoption within your webpack.config file, throughNxAppWebpackPlugin. This means that instead of accessingmylib/src/index.ts, it will accessdist/mylib/index.js.This directly aligns with incremental builds as it ensures that the build process only recompiles the source doe that has been modified since the last build.