Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): npm publish error when file path contains spaces #24750

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(release): npm publish error when file path contains spaces #24750

merged 1 commit into from
May 23, 2024

Conversation

dmcweeney
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #24682

@dmcweeney dmcweeney requested a review from a team as a code owner May 22, 2024 15:36
@dmcweeney dmcweeney requested a review from mandarini May 22, 2024 15:36
@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 22, 2024 3:44pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 22, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06733ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@FrozenPandaz
Copy link
Collaborator

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 261b0ff into nrwl:master May 23, 2024
6 checks passed
@dmcweeney dmcweeney deleted the fix-for-issue-24682-1 branch May 23, 2024 08:08
FrozenPandaz pushed a commit that referenced this pull request May 23, 2024
@dmcweeney @FrozenPandaz
fix(release): npm publish error when file path contains spaces (#24750)
2762f11 
## Current Behavior

## Expected Behavior

## Related Issue(s)

Fixes #24682

(cherry picked from commit 261b0ff)
FrozenPandaz pushed a commit that referenced this pull request May 23, 2024
@dmcweeney @FrozenPandaz
fix(release): npm publish error when file path contains spaces (#24750)
bc07797 
## Current Behavior

## Expected Behavior

## Related Issue(s)

Fixes #24682

(cherry picked from commit 261b0ff)
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@mandarini mandarini Awaiting requested review from mandarini mandarini is a code owner automatically assigned from nrwl/nx-js-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nx-release-publish fails if workspace file path contains a space
2 participants
@dmcweeney @FrozenPandaz