Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): fix swc version warning #24034

Merged
merged 1 commit into from
May 27, 2024

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

npm warnings:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @swc-node/[email protected]
npm WARN Found: @swc/[email protected]
npm WARN node_modules/@swc/core
npm WARN   dev @swc/core@"~1.3.85" from the root project
npm WARN   3 more (@swc-node/register, nx, ts-node)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @swc/core@">= 1.4.13" from @swc-node/[email protected]
npm WARN node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN   @swc-node/core@"^1.12.0" from @swc-node/[email protected]
npm WARN   node_modules/@swc-node/register
npm WARN 
npm WARN Conflicting peer dependency: @swc/[email protected]
npm WARN node_modules/@swc/core
npm WARN   peer @swc/core@">= 1.4.13" from @swc-node/[email protected]
npm WARN   node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN     @swc-node/core@"^1.12.0" from @swc-node/[email protected]
npm WARN     node_modules/@swc-node/register

Expected Behavior

Related Issue(s)

Fixes #23688

@xiongemi xiongemi requested review from a team as code owners May 22, 2024 00:43
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 27, 2024 5:37pm

@xiongemi xiongemi force-pushed the fix/fix-swc-version-warning branch 3 times, most recently from 0dde6c5 to 5554e20 Compare May 22, 2024 01:59
@xiongemi xiongemi requested a review from a team as a code owner May 22, 2024 01:59
@xiongemi xiongemi force-pushed the fix/fix-swc-version-warning branch from 5554e20 to da286fc Compare May 22, 2024 16:01
@xiongemi xiongemi force-pushed the fix/fix-swc-version-warning branch from da286fc to 6b927ff Compare May 22, 2024 16:35
@xiongemi xiongemi force-pushed the fix/fix-swc-version-warning branch from 6b927ff to c874551 Compare May 22, 2024 17:14
@xiongemi xiongemi requested a review from a team as a code owner May 22, 2024 17:14
@xiongemi xiongemi force-pushed the fix/fix-swc-version-warning branch from c874551 to 5601e76 Compare May 22, 2024 18:28
@xiongemi xiongemi requested review from a team as code owners May 22, 2024 18:28
@xiongemi xiongemi requested a review from jaysoo May 22, 2024 18:28
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add migrations as well please?

@FrozenPandaz FrozenPandaz merged commit a6e23c1 into nrwl:master May 27, 2024
6 checks passed
ndcunningham pushed a commit that referenced this pull request May 28, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
npm warnings:
```
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @swc-node/[email protected]
npm WARN Found: @swc/[email protected]
npm WARN node_modules/@swc/core
npm WARN   dev @swc/core@"~1.3.85" from the root project
npm WARN   3 more (@swc-node/register, nx, ts-node)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @swc/core@">= 1.4.13" from @swc-node/[email protected]
npm WARN node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN   @swc-node/core@"^1.12.0" from @swc-node/[email protected]
npm WARN   node_modules/@swc-node/register
npm WARN 
npm WARN Conflicting peer dependency: @swc/[email protected]
npm WARN node_modules/@swc/core
npm WARN   peer @swc/core@">= 1.4.13" from @swc-node/[email protected]
npm WARN   node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN     @swc-node/core@"^1.12.0" from @swc-node/[email protected]
npm WARN     node_modules/@swc-node/register
```

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23688
FrozenPandaz pushed a commit that referenced this pull request May 28, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
npm warnings:
```
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @swc-node/[email protected]
npm WARN Found: @swc/[email protected]
npm WARN node_modules/@swc/core
npm WARN   dev @swc/core@"~1.3.85" from the root project
npm WARN   3 more (@swc-node/register, nx, ts-node)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @swc/core@">= 1.4.13" from @swc-node/[email protected]
npm WARN node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN   @swc-node/core@"^1.12.0" from @swc-node/[email protected]
npm WARN   node_modules/@swc-node/register
npm WARN
npm WARN Conflicting peer dependency: @swc/[email protected]
npm WARN node_modules/@swc/core
npm WARN   peer @swc/core@">= 1.4.13" from @swc-node/[email protected]
npm WARN   node_modules/@swc-node/register/node_modules/@swc-node/core
npm WARN     @swc-node/core@"^1.12.0" from @swc-node/[email protected]
npm WARN     node_modules/@swc-node/register
```

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #23688

(cherry picked from commit a6e23c1)
Copy link

github-actions bot commented Jun 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx g lib creates invalid dependencies in package.json
2 participants