Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add bun package manager #19113

Closed

Conversation

Jordan-Hall
Copy link
Contributor

Bun uses yarn lock for it's binary file. Running the binary will produce the content of a yarn lock file (v1)

Other option is to use the -y command on add and install. This will create a yarn lock file and then createLockFile can just modify the yarn.lock file instead?

@Jordan-Hall Jordan-Hall requested review from meeroslav and a team as code owners September 11, 2023 21:03
@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 5:56pm

@alfaproject
Copy link
Contributor

Oh yay, support for bun as package manager would be VERY much appreciated!

@Jordan-Hall Jordan-Hall force-pushed the feat/add-bun-packagemanager branch 2 times, most recently from 929edc6 to 247c183 Compare September 14, 2023 16:12
@Jordan-Hall Jordan-Hall force-pushed the feat/add-bun-packagemanager branch from 247c183 to 1f5685d Compare September 14, 2023 16:36
@Jordan-Hall
Copy link
Contributor Author

I believe this is complete now. Using the same changes as a patch file currently with no issues

@Jordan-Hall
Copy link
Contributor Author

Bun 1.0.2 fixes the event loop so now appears to be working (unless they break anything else by mistake)

Bun uses yarn lock for it's binary file. Running the binary will produce the content of a yarn lock file (v1)
@Jordan-Hall
Copy link
Contributor Author

Jordan-Hall commented Sep 16, 2023

I'm closing this PR. Bun is amazing no doubt it maybe great. The team doing amazing things however its still way too young and running of hype.

Bun package manager is playing especially on NX repo. Using node as runtime 1.0.2 hasn't produce dis folder but claiming it ran ok which will be miss leading.

If anyone wants to use it, you can use patch package solution here the patch file: https://gist.github.com/Jordan-Hall/e910402a31b4a1e5a0b78324d6595618 its exactly the same as the PR

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants