UI tuning for OCR #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vietanhdev
commented
Dec 13, 2024
vietanhdev
commented
- Make window movable
- Hide screen capture with ESC
- Show preview for screen capture
- Scale the captured image to fit the preview
I think we should set the position of the preview better. If the capture region is low, the preview will be placed under it, which makes the buttons go below the desktop
|
@gallegi Fixed it, please check. |
|
There is another issue. The OCR image thumbnail is added to the UI, which means when we ask a follow up question, it will use the vision-language model, which is not what we intend to do @vietanhdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.