Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I create my own personal default init 0001? #78

Open
simkimsia opened this issue Jan 17, 2019 · 8 comments
Open

How do I create my own personal default init 0001? #78

simkimsia opened this issue Jan 17, 2019 · 8 comments

Comments

@simkimsia
Copy link

Hi @npryce , I discovered your adr-tools via ruthmalan. And now successfully using it in 3 existing projects and going on for more.

I like to ask if there's a way for me to change the default 0001 decision script without changing the code. Not looking to remove your existing content. but just to add 2 or 3 extra lines unique to my company under decision and context section.

Let me know roughly how and I be happy to try to make this my first contribution to your wonderful tool.

Thank you 🙏 with much ❤️ for your ADR tools 😄

@npryce
Copy link
Owner

npryce commented Jan 17, 2019

At the moment there’s no hook in the tool itself. However, you could build a wrapper script that calls adr init and then modifies the first adr or overwrites it.

@stephlag
Copy link

We would also need to change the link in the default 0001 decision as this is not an https link ant the site does not look very active anymore.
@npryce would it make sense to store Michael Nygard's paper in a github page and reference it in this "first" decision?

@npryce
Copy link
Owner

npryce commented Jan 17, 2019 via email

@simkimsia
Copy link
Author

simkimsia commented Jan 17, 2019

At the moment there’s no hook in the tool itself. However, you could build a wrapper script that calls adr init and then modifies the first adr or overwrites it.

I have this thought.

adr init <argument abt the location of the adr folder> --different-init-url <url to a different init.md file>

So what happens is that the init command with the optional flag --different-init-url will use a different init.md

of course any variable used in your default init.md like DATE should still work in the different init.md

What's your thoughts?

@npryce
Copy link
Owner

npryce commented Jan 17, 2019 via email

@simkimsia
Copy link
Author

simkimsia commented Jan 17, 2019

I’m not keen on the tool making requests over the network, because of the
much greater testing effort it will introduce.

Understood.

Do u mind if I try anyway in a separate fork? With tests as well. Out of purely intellectual curiosity.

Of course you are under no obligations to accept the PR and there's always the chance that I failed in my attempt.

If I fail, I will likely try the wrapper script option next.

@npryce
Copy link
Owner

npryce commented Jan 17, 2019 via email

@simkimsia
Copy link
Author

How about a file
rather than an HTTP URL? Then you can store a common default file on a
networked drive, and let the operating system handle security.

That's a great idea too! I'll try that.

no guarantees if I succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants