Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

Fixes error handling to create a Node Object when a child package is not exist #6

Closed
wants to merge 1 commit into from

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Dec 17, 2015

refs: npm/npm#10201 (comment)

Updates

  • Update rpc.js to update an error handling
  • Add badlink fixture
  • Add test case missing symlinks

@watilde watilde force-pushed the patch/fixes-error-handling branch from 905ee6f to c38df2d Compare December 17, 2015 20:04
@watilde watilde force-pushed the patch/fixes-error-handling branch from c38df2d to 32f9202 Compare January 4, 2016 23:47
@watilde
Copy link
Contributor Author

watilde commented Jan 11, 2016

@iarna Hi Rebecca, could you please see this for a issue is tagger big-issue when you have a time?

@iarna
Copy link
Contributor

iarna commented Jun 23, 2016

@watilde Oooh, I just ran across this, I wish I'd been looking in these PRs earlier!! I fully expect this to solve a whole class of ENOENT errors. Thank you for putting this together, I'm gonna get it merged ASAP.

@iarna
Copy link
Contributor

iarna commented Jun 23, 2016

Released as 5.1.5!

@iarna iarna closed this Jun 23, 2016
iarna added a commit to npm/npm that referenced this pull request Jun 24, 2016
Make bad symlinks be non-fatal errors when reading the tree off disk.

Credit: @watilde
Reviewed-By: @iarna
PR-URL: npm/read-package-tree#6
@watilde watilde deleted the patch/fixes-error-handling branch June 24, 2016 11:10
@zkat zkat mentioned this pull request Jul 1, 2016
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants