gar/provenance pr #6162
Merged
gar/provenance pr #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wraithgar
commented
Feb 13, 2023
•
wraithgar
commented
- feat: add provenance attestation
- fix: refactor error reporting in audit command
|
This is the actual PR to land for provenance. We are doing it this way so that the |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| t.test('publish existing package with provenance in gha', async t => { | ||
| const oidcURL = 'https://mock.oidc' | ||
| const requestToken = 'decafbad' |
Check failure
Code scanning / CodeQL
Hard-coded credentials
wraithgar
force-pushed
the
gar/provenance-pr
branch
from
92a3f6f to
c734342
Compare
|
no statistically significant performance changes detected timing results
|
wraithgar
force-pushed
the
gar/provenance-pr
branch
from
c734342 to
b08e27d
Compare
ljharb
reviewed
Feb 13, 2023
This adds a new `--provenance` flag to npm for provenance attestation during `npm publish` If set to `true`, npm will detect if it is running in GitHub actions and will generate an appropriate attestation bundle for that environment. The primary work in this PR was done by [@bdehamer](https://github.com/bdehamer), with some cleanup and edge-case handling added by the npm cli team.
wraithgar
force-pushed
the
gar/provenance-pr
branch
2 times, most recently
from
b7778c8 to
43dd4d8
Compare
ljharb
reviewed
Feb 13, 2023
Primary work authored by [@wraithgar](https://github.com/wraithgar).
wraithgar
force-pushed
the
gar/provenance-pr
branch
from
43dd4d8 to
cc61923
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.