Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully fallback from auth-type=web #6158

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

MylesBorins
Copy link
Contributor

Originally auth-type=web would gracefully fallback to auth-type=legacy if a registry had not yet implemented web. This brings back that behavior.

@MylesBorins MylesBorins requested a review from a team as a code owner February 10, 2023 20:40
@MylesBorins MylesBorins requested review from nlf and removed request for a team February 10, 2023 20:40
@MylesBorins MylesBorins force-pushed the graceful-auth-type branch 2 times, most recently from 763f525 to 110d753 Compare February 10, 2023 20:45
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Feb 10, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.412 ±2.57 18.148 ±0.12 16.587 ±0.05 19.094 ±0.73 3.035 ±0.06 3.010 ±0.00 2.381 ±0.02 11.574 ±0.04 2.408 ±0.04 3.576 ±0.11
#6158 38.084 ±2.70 17.827 ±0.06 16.562 ±0.05 19.341 ±0.87 3.041 ±0.01 3.004 ±0.01 2.348 ±0.00 11.630 ±0.05 2.351 ±0.01 3.834 ±0.55
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 25.462 ±1.48 14.103 ±0.06 12.867 ±0.02 13.778 ±0.05 2.711 ±0.03 2.733 ±0.04 2.437 ±0.04 8.846 ±0.00 2.270 ±0.01 3.187 ±0.05
#6158 26.328 ±2.33 14.444 ±0.45 12.979 ±0.03 13.827 ±0.22 2.758 ±0.03 2.809 ±0.08 2.332 ±0.01 8.919 ±0.03 2.210 ±0.05 3.181 ±0.01

@Ibrahim11a

This comment was marked as spam.

Originally `auth-type=web` would gracefully fallback to
`auth-type=legacy` if a registry had not yet implemented
web. This brings back that behavior.
@wraithgar wraithgar changed the title auth-type: gracefully fallback from web fix: gracefully fallback from auth-type=web Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants