-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update republish time and lightly reorganize republish info #48
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,14 +24,13 @@ If no version is specified, or if all versions are removed then | |
the root package entry is removed from the registry entirely. | ||
|
||
Even if a package version is unpublished, that specific name and | ||
version combination can never be reused. In order to publish the | ||
package again, a new version number must be used. | ||
version combination can never be reused. In order to publish the | ||
package again, a new version number must be used. Additionally, | ||
new versions of unpublished packages may not be republished until 24 hours | ||
have passed. | ||
|
||
With the default registry (`registry.npmjs.org`), unpublish is | ||
only allowed with versions published in the last 72 hours. Similarly, | ||
new versions of unpublished packages may not be republished until 72 hours | ||
have passed. If you are trying to unpublish a version published longer | ||
ago than that, contact [email protected]. | ||
only allowed with versions published in the last 72 hours. If you are trying to unpublish a version published longer ago than that, contact [email protected]. | ||
|
||
The scope is optional and follows the usual rules for `npm-scope(7)`. | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t seem accurate; new versions can be published immediately, altho the old version can never be republished.
Is this a new requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entirely unpublished packages have a 24 hour delay before they can be published again. This isn't particularly new, but it's not widely known, thus these docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh ok so it’s only if there remains no published versions, then there’s a 24 hour delay?
Maybe the wording here could be like “fully unpublished” or “new versions of packages with every version unpublished”, so it’s clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that rewording, tbh.