fix: lint all files in lib/ folder #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
added
Release 7.x
|
How was this working then if the existing glob was wrong? |
|
If I make a linting error in a file in lib it currently fails linting /Users/wraithgar/Development/npm/cli/lib/unpublish.js
118:11 error 'foo' is assigned a value but never used no-unused-vars
119:11 error Missing trailing comma comma-dangle |
|
I suppose there is no need for the glob. I wonder if there used to be non |
wraithgar
approved these changes
May 13, 2021
PR-URL: npm#3237 Credit: @ruyadorno Close: npm#3237 Reviewed-by: @wraithgar
ruyadorno
force-pushed
the
fix-lint-script
branch
from
302315f to
9c46a0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current glob is missing
lib/*.jsfiles.