Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the extracted stringify-package module #21

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

dpogue
Copy link
Contributor

@dpogue dpogue commented Jul 18, 2018

stringify-package has been extracted into its own module.

Not sure if I should be committing the stringify-package folder under node_modules and adding it to bundledDependencies as well?

@dpogue dpogue requested a review from a team as a code owner July 18, 2018 18:45
@zkat
Copy link
Contributor

zkat commented Jul 18, 2018

@dpogue In order to add a dependency, you need to:

  1. npm install -B <dep> (-B bundles it)
  2. git add -A node_modules package.json package-lock.json
  3. git commit

We keep all our deps in the repo.

@dpogue dpogue force-pushed the stringify-package branch from 3df0d1c to 340e34f Compare July 18, 2018 22:34
@dpogue
Copy link
Contributor Author

dpogue commented Jul 18, 2018

Thanks @zkat. Updated to bundle the dependency and now all the CI tests are green :)

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for taking care of that. This lgtm and I think we're gtg!

@zkat zkat changed the base branch from latest to release-next July 19, 2018 00:54
@zkat zkat merged commit a9ac871 into npm:release-next Jul 19, 2018
@dpogue dpogue deleted the stringify-package branch July 19, 2018 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants