fix make release #2068
Closed
fix make release #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
Release 7.x
nlf
force-pushed
the
nlf/fix-make-release
branch
from
df27c7b to
6422744
Compare
nlf
force-pushed
the
nlf/fix-make-release
branch
from
b2c4838 to
8de9955
Compare
ruyadorno
approved these changes
Oct 29, 2020
darcyclarke
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the docs dependencies were moved to the top level we inadvertently broke the
make releasecommand causing issues when integrating with the node project.these changes fix
make releaseso that we appropriately build the tarball for vendoring purposes