Adding failure-capture information to exception message. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def message | ||
| 'Invalid Swagger version spec supplied. Svelte supports Swagger v2 only' | ||
| %-"swagger" field is #{@supplied_version or 'empty'}. Svelte only supports Swagger v2.0.- |
There was a problem hiding this comment.
Tradition would be to use %Q{} rather than other delimeters. (Matched delimeters can handle themselves quite well)
|
Something to bear in mind, the swagger version key changed in swagger 2 as well, so in swagger 2 is |
|
@brafales I think it's better to just not be able to detect it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AgentAntelope @brafales @AdColvinNOTHS I thought I'd do a quick bit of lunchtime ruby!
One thing I always find useful is capturing the values of parameters that lead to an exception in its message. This greatly helps a developer faced with this exception.
I have no doubt that my implementation is not idiomatic ruby, so I'm prepared for comments or all out rejection. :-)