Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add execute command to handle Execute code lens #31

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Aug 15, 2023

Description

Problem*

Ref noir-lang/noir#2330

Summary*

This adds a nargo.execute command that will be triggered via the > Execute code lens.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Base automatically changed from phated/compile-task to master August 16, 2023 16:04
@phated phated force-pushed the phated/execute-task branch from 78fe2a9 to 8e22cd7 Compare August 16, 2023 16:08
@phated phated marked this pull request as ready for review August 16, 2023 16:08
@phated phated requested review from TomAFrench and kobyhallx August 16, 2023 16:08
@TomAFrench
Copy link
Member

I'm building this with npm run package (and then selecting "Install Extension VSIX" in the sidebar) and running it with Nargo built from your PR. I'm not getting any display and a "Unable to locate any nargo binary. Did you install it?" error.

Should I be doing something different to test this?

@phated
Copy link
Contributor Author

phated commented Aug 16, 2023

So the published extension doesn't work for you either? I use a custom absolute path to my nargo binary since I iterate on the features so I've not experienced this. Seems entirely unrelated to this PR

@TomAFrench
Copy link
Member

Yeah, I really doubt it has anything to do with this PR. Just trying to get to a state where I can meaningfully test it.

@phated
Copy link
Contributor Author

phated commented Aug 16, 2023

I'm guessing that your vscode shell doesn't have access to a nargo in its path. I'm going to see if I can replicate but you can also add a hardcoded path in settings.

@TomAFrench
Copy link
Member

I don't get any errors on the published extension (v0.0.3) but nothing past syntax highlighting either. I've switched back to the locally installed extension and don't get the error anymore but no output either. Adding an explicit path causes no change.

@TomAFrench
Copy link
Member

Ah ha! I've managed to get signs of life.

@TomAFrench
Copy link
Member

Ok, I can execute circuits using this now.

@phated phated merged commit 7eb8a52 into master Aug 16, 2023
@phated phated deleted the phated/execute-task branch August 16, 2023 17:45
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants