chore: move sha2 functions into the `hash` module #5768

TomAFrench · 2024-08-20T12:37:31Z

Description

Problem*

Resolves

Summary*

This PR organises the sha2 functions so that they sit under std::hash. I've maintained reexports such that user code isn't broken (we can remove these at the 1.0 release)

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2024-08-21T09:57:19Z

Changes to Brillig bytecode sizes

Generated at commit: e199f9c8a7fe3b37a2b75bea7b2b87ceefc92825, compared to commit: 1958a7932642e2fa556a903a3186b142a70e3e48

There are no changes in circuit sizes

noir_stdlib/src/hash/mod.nr

github-actions · 2024-08-21T10:58:38Z

🚀 Deployed on https://66c5c84feca0da00a19ee2a7--noir-docs.netlify.app

github-actions · 2024-08-21T10:58:48Z

FYI @noir-lang/developerrelations on Noir doc changes.

…r-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

…ents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

…ang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

…5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

…5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

…5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

feat: Improve "type annotations needed" errors (noir-lang/noir#5830) chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421) chore: delete wip fuzzing files that got accidentally added (noir-lang/noir#5829) chore: test ACVM `BigInt` (noir-lang/noir#5559) fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826) fix: bit shifting type checking (noir-lang/noir#5824) feat: add Expr::as_method_call (noir-lang/noir#5822) chore: Fix docs typo (noir-lang/noir#5821) feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804) chore: Add docs for each comptime method (noir-lang/noir#5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: crypto blackbox tests (noir-lang/noir#5614) feat: Improve "type annotations needed" errors (noir-lang/noir#5830) chore: enum dummy ID for `FuncId` in monomorphizer and docstring fixes (noir-lang/noir#5421) chore: delete wip fuzzing files that got accidentally added (noir-lang/noir#5829) chore: test ACVM `BigInt` (noir-lang/noir#5559) fix(docs): Fix file paths for metaprogramming docs (noir-lang/noir#5826) fix: bit shifting type checking (noir-lang/noir#5824) feat: add Expr::as_method_call (noir-lang/noir#5822) chore: Fix docs typo (noir-lang/noir#5821) feat: add `UnresolvedType::is_field` and `Expr::as_assign` (noir-lang/noir#5804) chore: Add docs for each comptime method (noir-lang/noir#5802) chore: Add comptime docs (noir-lang/noir#5800) fix: Handle multiple entry points for Brillig call stack resolution after metadata deduplication (noir-lang/noir#5788) fix(acir_gen): Nested dynamic array initialization (noir-lang/noir#5810) fix: honor function visibility in LSP completion (noir-lang/noir#5809) feat: LSP completion now works better in the middle of idents (noir-lang/noir#5795) feat: Explicit Associated Types & Constants (noir-lang/noir#5739) feat: add `Expr::as_cast` and `UnresolvedType::is_field` (noir-lang/noir#5801) feat: add `Expr` methods: as_comptime, as_unsafe, is_break, is_continue (noir-lang/noir#5799) fix: do not use predicate for index in array operation, when the index is safe (noir-lang/noir#5779) chore: Toggle underconstrained check (noir-lang/noir#5724) feat: Add `Expr::as_block` and `Expr::has_semicolon` (noir-lang/noir#5784) feat: LSP hover and go-to-definition for crates (noir-lang/noir#5786) fix(acvm): Clear ACIR call stack after successful circuit execution (noir-lang/noir#5783) chore: sanitize url's to only allow github (noir-lang/noir#5776) chore: enable constant inputs for more blackbox (noir-lang/noir#5647) chore: move sha2 functions into the `hash` module (noir-lang/noir#5768) END_COMMIT_OVERRIDE --------- Co-authored-by: sirasistant <[email protected]> Co-authored-by: Maxim Vezenov <[email protected]>

TomAFrench added 2 commits August 20, 2024 13:32

chore: move sha2 functions to within hash module

18f0601

chore: more reorganising

8ec7e69

jfecher approved these changes Aug 20, 2024

View reviewed changes

TomAFrench added 2 commits August 21, 2024 09:50

chore: fix imports

5c54d35

.

e6e83ee

.

0d39d04

TomAFrench commented Aug 21, 2024

View reviewed changes

noir_stdlib/src/hash/mod.nr Outdated Show resolved Hide resolved

Update noir_stdlib/src/hash/mod.nr

e34b013

TomAFrench enabled auto-merge August 21, 2024 10:13

TomAFrench added this pull request to the merge queue Aug 21, 2024

TomAFrench removed this pull request from the merge queue due to a manual request Aug 21, 2024

chore: fix docs snippet

59747ac

github-actions bot added the documentation Improvements or additions to documentation label Aug 21, 2024

TomAFrench added this pull request to the merge queue Aug 21, 2024

Merged via the queue into master with commit eba5312 Aug 21, 2024
47 checks passed

TomAFrench deleted the tf/reorg-sha2 branch August 21, 2024 11:13

AztecBot mentioned this pull request Aug 22, 2024

feat: Sync from noir AztecProtocol/aztec-packages#8125

Merged

AztecBot mentioned this pull request Aug 27, 2024

chore(master): Release 0.51.0 AztecProtocol/aztec-packages#8158

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: move sha2 functions into the `hash` module #5768

chore: move sha2 functions into the `hash` module #5768

TomAFrench commented Aug 20, 2024

github-actions bot commented Aug 21, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

chore: move sha2 functions into the hash module #5768

chore: move sha2 functions into the hash module #5768

Conversation

TomAFrench commented Aug 20, 2024

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

github-actions bot commented Aug 21, 2024 • edited Loading

Changes to Brillig bytecode sizes

There are no changes in circuit sizes

github-actions bot commented Aug 21, 2024

github-actions bot commented Aug 21, 2024

chore: move sha2 functions into the `hash` module #5768

chore: move sha2 functions into the `hash` module #5768

github-actions bot commented Aug 21, 2024 •

edited

Loading