feat: Sync from aztec-packages

.aztec-sync-commit

@@ -1 +1 @@
-7ff9b71d8d87fc93ae7dbd8ba63f5176b0cd17be
+07dd8215dffd2c3c6d22e0f430f5072b4ff7c763

Cargo.toml

@@ -26,6 +26,7 @@ members = [
     "tooling/nargo_toml",
     "tooling/noirc_abi",
     "tooling/noirc_abi_wasm",
+    "tooling/acvm_cli",
     # ACVM
     "acvm-repo/acir_field",
     "acvm-repo/acir",
@@ -36,7 +37,7 @@ members = [
     "acvm-repo/blackbox_solver",
     "acvm-repo/bn254_blackbox_solver",
 ]
-default-members = ["tooling/nargo_cli"]
+default-members = ["tooling/nargo_cli", "tooling/acvm_cli"]
 resolver = "2"
 
 [workspace.package]
@@ -78,6 +79,7 @@ noir_lsp = { path = "tooling/lsp" }
 noir_debugger = { path = "tooling/debugger" }
 noirc_abi = { path = "tooling/noirc_abi" }
 bb_abstraction_leaks = { path = "tooling/bb_abstraction_leaks" }
+acvm_cli = { path = "tooling/acvm_cli" }
 
 # LSP
 async-lsp = { version = "0.1.0", default-features = false }

aztec_macros/src/lib.rs

@@ -445,7 +445,7 @@
             } else if is_custom_attribute(&secondary_attribute, "aztec(initializer)") {
                 is_initializer = true;
                 insert_init_check = false;
             } else if is_custom_attribute(&secondary_attribute, "aztec(noinitcheck)") {
                 insert_init_check = false;
             } else if is_custom_attribute(&secondary_attribute, "aztec(internal)") {
                 is_internal = true;
@@ -727,8 +727,14 @@
 /// Transform a function to work with AVM bytecode
 fn transform_vm_function(
     func: &mut NoirFunction,
-    _storage_defined: bool,
+    storage_defined: bool,
 ) -> Result<(), AztecMacroError> {
+    // Create access to storage
+    if storage_defined {
+        let storage = abstract_storage("public_vm", true);
+        func.def.body.0.insert(0, storage);
+    }
+
     // Push Avm context creation to the beginning of the function
     let create_context = create_avm_context()?;
     func.def.body.0.insert(0, create_context);
@@ -1754,8 +1760,8 @@
     // If compute_note_hash_and_nullifier is already defined by the user, we skip auto-generation in order to provide an
     // escape hatch for this mechanism.
     // TODO(#4647): improve this diagnosis and error messaging.
     if collected_functions.iter().any(|coll_funcs_data| {
         check_for_compute_note_hash_and_nullifier_definition(&coll_funcs_data.functions, module_id)
     }) {
         return Ok(());
     }
@@ -1809,7 +1815,7 @@
     unresolved_traits_impls: &[UnresolvedTraitImpl],
     trait_name: &str,
 ) -> Vec<String> {
     let mut struct_typenames: Vec<String> = Vec::new();
 
     // These structs can be declared in either external crates or the current one. External crates that contain
     // dependencies have already been processed and resolved, but are available here via the NodeInterner. Note that
@@ -1819,7 +1825,7 @@
 
         if trait_impl.borrow().ident.0.contents == *trait_name {
             if let Type::Struct(s, _) = &trait_impl.borrow().typ {
                 struct_typenames.push(s.borrow().name.0.contents.clone());
             } else {
                 panic!("Found impl for {} on non-Struct", trait_name);
             }
@@ -1827,7 +1833,7 @@
     }
 
     // This crate's traits and impls have not yet been resolved, so we look for impls in unresolved_trait_impls.
     struct_typenames.extend(
         unresolved_traits_impls
             .iter()
             .filter(|trait_impl| {
@@ -1848,7 +1854,7 @@
             }),
     );
 
     struct_typenames
 }
 
 fn generate_compute_note_hash_and_nullifier(note_types: &Vec<String>) -> NoirFunction {
@@ -1869,8 +1875,8 @@
     // For now we hardcode it to 20, which is the same as MAX_NOTE_FIELDS_LENGTH.
 
     if note_types.is_empty() {
-        // TODO(#4520): Even if the contract does not include any notes, other parts of the stack expect for this
-        // function to exist, so we include a dummy version. We likely should error out here instead.
+        // Even if the contract does not include any notes, other parts of the stack expect for this function to exist,
+        // so we include a dummy version.
         "
         unconstrained fn compute_note_hash_and_nullifier(
             contract_address: AztecAddress,
@@ -1879,6 +1885,7 @@
             note_type_id: Field,
             serialized_note: [Field; 20]
         ) -> pub [Field; 4] {
+            assert(false, \"This contract does not use private notes\");
             [0, 0, 0, 0]
         }"
         .to_string()
@@ -1892,10 +1899,10 @@
             }}"
         , note_type)).collect();
 
-        // TODO(#4520): error out on the else instead of returning a zero array
         let full_if_statement = if_statements.join(" else ")
             + "
             else {
+                assert(false, \"Unknown note type ID\");
                 [0, 0, 0, 0]
             }";
 

bootstrap.sh

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+set -eu
+
+cd $(dirname "$0")
+
+CMD=${1:-}
+
+if [ -n "$CMD" ]; then
+  if [ "$CMD" = "clean" ]; then
+    git clean -fdx
+    exit 0
+  else
+    echo "Unknown command: $CMD"
+    exit 1
+  fi
+fi
+
+# Attempt to just pull artefacts from CI and exit on success.
+[ -n "${USE_CACHE:-}" ] && ./bootstrap_cache.sh && exit
+
+./scripts/bootstrap_native.sh
+./scripts/bootstrap_packages.sh

bootstrap_cache.sh

@@ -0,0 +1,13 @@
+#!/usr/bin/env bash
+set -eu
+
+cd "$(dirname "$0")"
+source ../build-system/scripts/setup_env '' '' mainframe_$USER > /dev/null
+
+echo -e "\033[1mRetrieving noir packages from remote cache...\033[0m"
+extract_repo noir-packages /usr/src/noir/packages ./
+echo -e "\033[1mRetrieving nargo from remote cache...\033[0m"
+extract_repo noir /usr/src/noir/target/release ./target/
+
+remove_old_images noir-packages
+remove_old_images noir

compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs

@@ -831,16 +831,10 @@ impl<'block> BrilligBlock<'block> {
             _ => unreachable!("ICE: array set on non-array"),
         };
 
+        // Here we want to compare the reference count against 1.
         let one = self.brillig_context.make_usize_constant(1_usize.into());
         let condition = self.brillig_context.allocate_register();
-
-        self.brillig_context.binary_instruction(
-            reference_count,
-            one,
-            condition,
-            BrilligBinaryOp::Field { op: BinaryFieldOp::Equals },
-        );
-
+        self.brillig_context.memory_op(reference_count, one, condition, BinaryIntOp::Equals);
         self.brillig_context.branch_instruction(condition, |ctx, cond| {
             if cond {
                 // Reference count is 1, we can mutate the array directly

compiler/noirc_evaluator/src/brillig/brillig_ir.rs

@@ -27,12 +27,11 @@ use acvm::{
     FieldElement,
 };
 use debug_show::DebugShow;
-use num_bigint::BigUint;
 
 /// The Brillig VM does not apply a limit to the memory address space,
 /// As a convention, we take use 64 bits. This means that we assume that
 /// memory has 2^64 memory slots.
-pub(crate) const BRILLIG_MEMORY_ADDRESSING_BIT_SIZE: u32 = 32;
+pub(crate) const BRILLIG_MEMORY_ADDRESSING_BIT_SIZE: u32 = 64;
 
 // Registers reserved in runtime for special purposes.
 pub(crate) enum ReservedRegisters {
@@ -213,13 +212,7 @@ impl BrilligContext {
         self.debug_show.array_get(array_ptr, index, result);
         // Computes array_ptr + index, ie array[index]
         let index_of_element_in_memory = self.allocate_register();
-        self.binary_instruction(
-            array_ptr,
-            index,
-            index_of_element_in_memory,
-            BrilligBinaryOp::Field { op: BinaryFieldOp::Add },
-        );
-
+        self.memory_op(array_ptr, index, index_of_element_in_memory, BinaryIntOp::Add);
         self.load_instruction(result, index_of_element_in_memory);
         // Free up temporary register
         self.deallocate_register(index_of_element_in_memory);
@@ -239,7 +232,10 @@ impl BrilligContext {
             array_ptr,
             index,
             index_of_element_in_memory,
-            BrilligBinaryOp::Field { op: BinaryFieldOp::Add },
+            BrilligBinaryOp::Integer {
+                op: BinaryIntOp::Add,
+                bit_size: BRILLIG_MEMORY_ADDRESSING_BIT_SIZE,
+            },
         );
 
         self.store_instruction(index_of_element_in_memory, value);
@@ -562,6 +558,7 @@ impl BrilligContext {
         bit_size: u32,
     ) {
         self.debug_show.const_instruction(result, constant);
+
         self.push_opcode(BrilligOpcode::Const { destination: result, value: constant, bit_size });
     }
 
@@ -725,6 +722,8 @@ impl BrilligContext {
     /// Instead truncation instructions are emitted as to when a
     /// truncation should be done.
     /// For Brillig, all integer operations will overflow as its cheap.
+    /// We currently use cast to truncate: we cast to the required bit size
+    /// and back to the original bit size.
     pub(crate) fn truncate_instruction(
         &mut self,
         destination_of_truncated_value: SingleAddrVariable,
@@ -743,20 +742,12 @@ impl BrilligContext {
             value_to_truncate.bit_size
         );
 
-        let mask = BigUint::from(2_u32).pow(bit_size) - BigUint::from(1_u32);
-        let mask_constant = self.make_constant(
-            FieldElement::from_be_bytes_reduce(&mask.to_bytes_be()).into(),
-            value_to_truncate.bit_size,
-        );
-
-        self.binary_instruction(
-            value_to_truncate.address,
-            mask_constant,
-            destination_of_truncated_value.address,
-            BrilligBinaryOp::Integer { op: BinaryIntOp::And, bit_size: value_to_truncate.bit_size },
-        );
-
-        self.deallocate_register(mask_constant);
+        // We cast back and forth to ensure that the value is truncated.
+        let intermediate_register =
+            SingleAddrVariable { address: self.allocate_register(), bit_size };
+        self.cast_instruction(intermediate_register, value_to_truncate);
+        self.cast_instruction(destination_of_truncated_value, intermediate_register);
+        self.deallocate_register(intermediate_register.address);
     }
 
     /// Emits a stop instruction

compiler/wasm/test/fixtures/deps/lib-c/src/lib.nr

@@ -1 +1 @@
-mod module;
+mod module;

compiler/wasm/test/fixtures/deps/lib-c/src/module.nr

@@ -1 +1 @@
-mod foo;
+mod foo;

compiler/wasm/test/fixtures/deps/lib-c/src/module/foo.nr

@@ -1,3 +1,3 @@
 pub fn bar(param: Field) -> Field {
-  dep::std::hash::pedersen_hash([param])
+    dep::std::hash::pedersen_hash([param])
 }

compiler/wasm/test/fixtures/noir-contract/src/main.nr

@@ -8,5 +8,4 @@ contract TestContract {
     open fn openFunction() -> pub Field {
         42
     }
-
 }

docs/scripts/codegen_nargo_reference.sh

@@ -30,4 +30,4 @@ sidebar_position: 0
 ---
 " > $NARGO_REFERENCE
 
-cargo run -F codegen-docs -- info >> $NARGO_REFERENCE
+cargo run --bin nargo -F codegen-docs -- info >> $NARGO_REFERENCE

test_programs/compile_failure/assert_msg_runtime/src/main.nr

@@ -4,4 +4,4 @@ fn main(x: Field, y: pub Field) {
     let z = x + y;
     assert(z != y, f"Expected z != y, but got both equal {z}");
     assert_eq(x, y, f"Expected x == y, but x is {x} and y is {y}");
-}
+}

test_programs/compile_failure/brillig_assert_msg_runtime/src/main.nr

@@ -7,4 +7,4 @@ unconstrained fn conditional(x: Field) -> Field {
     assert_eq(z, 25, f"Expected 25 but got {z}");
     assert(x == 10, f"Expected x to equal 10, but got {x}");
     1
-}
+}

test_programs/compile_failure/brillig_mut_ref_from_acir/src/main.nr

@@ -5,4 +5,4 @@ unconstrained fn mut_ref_identity(value: &mut Field) -> Field {
 fn main(mut x: Field, y: pub Field) {
     let returned_x = mut_ref_identity(&mut x);
     assert(returned_x == x);
-}
+}

test_programs/compile_success_contract/contract_with_impl/src/main.nr

@@ -2,6 +2,6 @@ contract Foo {
     struct T { x: [Field] }
 
     impl T {
-        fn t(self){}
+        fn t(self) {}
     }
 }

test_programs/compile_success_contract/simple_contract/src/main.nr

@@ -13,7 +13,7 @@ contract Foo {
     }
     // Regression for issue #3344
     #[contract_library_method]
-    fn foo(x : u8) -> u8 {
+    fn foo(x: u8) -> u8 {
         x
     }
 }