Trait where clause isn't type-checked #6023
Assignees
Labels
bug
Something isn't working
Comments
|
@noir-lang/core Actually, it seems a trait's where clause is completely ignored. "Find all references" of |
|
I didn't know we allowed where clauses in this position at all. Checking these is somewhat similar to trait inheritance (which we also don't support) where we'd need to check/assume it everywhere the trait is used. |
asterite
changed the title
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 24, 2024
# Description ## Problem Resolves #6023 ## Summary It turns out that checking a trait's `where` clause is very similar to checking parent traits: for parent traits the type to check if `Self`, for where clause it's the specified type. So `trait Foo where Self: Constraint` is the same as `trait Foo: Constraint`. I thought about unifying the code to only have a single list of constraints but I don't know if it's worth it (we could maybe give different errors in one case or another, though right now the errors are the same). There's a chance this PR is a breaking change, because when I finished implementing it one test broke and I had to amend it. ## Additional Context ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
This program:
doesn't give an error.
Expected Behavior
The compiler should say that it can't find
Unknown.Bug
The compiler doesn't error.
To Reproduce
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
None
Blocker Context
No response
Nargo Version
No response
NoirJS Version
No response
Proving Backend Tooling & Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: