Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS packages failed to publish #4634

Closed
github-actions bot opened this issue Mar 25, 2024 · 1 comment · Fixed by #4638
Closed

JS packages failed to publish #4634

github-actions bot opened this issue Mar 25, 2024 · 1 comment · Fixed by #4638
Assignees
@TomAFrench @Savio-Sou
Labels
js Noir's JavaScript packages

Comments

@github-actions
Copy link
Contributor

The release of the JS packages failed.

Check the Publish JS packages workflow for details.

This issue was raised by the workflow Publish ACVM crates
@github-actions github-actions bot added the js Noir's JavaScript packages label Mar 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 25, 2024
@Savio-Sou
Copy link
Collaborator 

Uploading bn254_blackbox_solver v0.39.0 (/home/runner/work/noir/noir/acvm-repo/bn254_blackbox_solver)
error: failed to publish to registry at https://crates.io/

Caused by:
  the remote server responded with an error (status 400 Bad Request): crate version `0.39.0` is already uploaded

https://github.com/noir-lang/noir/actions/runs/8427335952/job/23077648443#step:8:428

This was referenced Mar 26, 2024
Merged
Merged
TomAFrench added a commit that referenced this issue Mar 26, 2024
@TomAFrench
chore: fix acvm crates reporting errors as JS packages (#4637)
d6f1043 
# Description

## Problem\*

Addresses incorrect content of #4634

## Summary\*

We were raising an alert for a bad publish of the ACVM crates as if they
were the JS packages so this PR updates the alert to be consistent.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
TomAFrench added a commit that referenced this issue Mar 26, 2024
@TomAFrench
chore: fix versioning of bn254_blackbox_solver crate (#4638)
10f182a 
# Description

## Problem\*

Resolves #4634 

## Summary\*

The ACVM crate publishing steps are failing because when
`barretenberg_blackbox_solver` was renamed to `bn254_blackbox_solver`
the release please config wasn't updated to match, resulting in the
version not being incremented on releases.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Mar 26, 2024
TomAFrench added a commit that referenced this issue Apr 3, 2024
@TomAFrench
chore: fix acvm crates reporting errors as JS packages (#4637)
7509310 
# Description

## Problem\*

Addresses incorrect content of #4634

## Summary\*

We were raising an alert for a bad publish of the ACVM crates as if they
were the JS packages so this PR updates the alert to be consistent.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
TomAFrench added a commit that referenced this issue Apr 3, 2024
@TomAFrench
chore: fix versioning of bn254_blackbox_solver crate (#4638)
64b7e42 
# Description

## Problem\*

Resolves #4634 

## Summary\*

The ACVM crate publishing steps are failing because when
`barretenberg_blackbox_solver` was renamed to `bn254_blackbox_solver`
the release please config wasn't updated to match, resulting in the
version not being incremented on releases.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

@Savio-Sou Savio-Sou

Labels
js Noir's JavaScript packages
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix versioning of bn254_blackbox_solver crate noir-lang/noir
2 participants
@TomAFrench @Savio-Sou