Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow print without newline #3575

Closed
grasshopper47 opened this issue Nov 25, 2023 · 1 comment
Closed

Allow print without newline #3575

grasshopper47 opened this issue Nov 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@grasshopper47
Copy link
Contributor

Problem

Sometimes printing without a new line is needed, for example when printing slice contents.

Happy Case

Since Noir is Rust-like, having a print method alongside println seems like a good idea.

Alternatives Considered

Support ANSI terminal codes ? 🙃

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response
@grasshopper47 grasshopper47 added the enhancement New feature or request label Nov 25, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Nov 25, 2023
@grasshopper47 grasshopper47 mentioned this issue Nov 25, 2023
Closed
5 tasks
@grasshopper47
Copy link
Contributor Author

@vezenovm I've submitted a PR for this here: #3576

@grasshopper47 grasshopper47 mentioned this issue Nov 30, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
@grasshopper47 @jfecher
feat: Implement print without newline (#3650)
9827dfe 
# Description

## Problem\*

Resolves  **#3575
Resolves **#2912 (duplicate)

Continuation of #3576
## Summary\*

Refactors `println_oracle` method into `print` with boolean indicator,
allowing `print` to coexist with `println` under the same `ForeignCall`
string symbol.
Updates appropriate tests, and logging.md documentation.
Add a subchapter to `03_string.md` documentation for the `fmtstr` type

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement print method grasshopper47/noir
1 participant
@grasshopper47