Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WG Charter #626

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Added WG Charter #626

merged 3 commits into from
Apr 16, 2021

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Mar 26, 2021

Adds the WG charter.

Fixes #580

@mcollina mcollina requested review from ronag and dnlup March 26, 2021 12:00
@mcollina
Copy link
Member Author

cc @nodejs/tsc

@codecov-io
Copy link

codecov-io commented Mar 26, 2021

Codecov Report

Merging #626 (7bceb7b) into main (f06375e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #626   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1892      1892           
=========================================
  Hits          1892      1892           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06375e...7bceb7b. Read the comment docs.

@mcollina
Copy link
Member Author

mcollina commented Mar 26, 2021

Don't land as it needs to wait for the TSC. I've set it to draft so that they have time to approve it.

@mcollina mcollina marked this pull request as draft March 26, 2021 12:11
GOVERNANCE.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@mcollina this has probably had enough time for people to object if they were going to. Do you want to move out of draft ?

@mcollina mcollina marked this pull request as ready for review April 15, 2021 23:15
@mcollina mcollina merged commit d063afc into main Apr 16, 2021
@mcollina mcollina deleted the add-governance branch April 16, 2021 15:28
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* Added WG Charter

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charterining Undici as a full working group
7 participants