Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links in undici webpage #3807

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

dancastillo
Copy link
Contributor

This relates to...

#3322
#3748

Rationale

Changes

Using renderer for links can format them to route to appropriate page and not break readmes in github repo.

Absolute links will need to be used updated them for links in docs/docs/api/ instead of relative links

fix-links-in-webpage.mov

Features

Bug Fixes

#3322
#3748

Breaking Changes and Deprecations

Status

docs/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho needs to be stricter, see suggestion

@dancastillo dancastillo requested a review from Uzlopak November 8, 2024 13:20
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit d62731c into nodejs:main Nov 10, 2024
36 checks passed
flakey5 pushed a commit to flakey5/undici that referenced this pull request Nov 14, 2024
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants