replace instanceof in brand checks with isPrototypeOf #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Oct 7, 2024
| const headersToBrandCheck = globalThis.Headers | ||
| ? [Headers, globalThis.Headers] | ||
| : [Headers] | ||
| const brandChecks = webidl.brandCheckMultiple([Headers, globalThis.Headers].filter(Boolean)) |
There was a problem hiding this comment.
What if you run node with --no-experimental-fetch? Then globalThis.Headers will be undefined. Thus breaking the code.
There was a problem hiding this comment.
that's what the .filter(Boolean) is for
metcoder95
approved these changes
Oct 7, 2024
Uzlopak
approved these changes
Oct 7, 2024
mcollina
added
the
semver-major
|
@mcollina I don't think this is semver-major? |
flakey5
pushed a commit
to flakey5/undici
that referenced
this pull request
Oct 8, 2024
* replace instanceof in brand checks with isPrototypeOf * fix types
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side note, but not majorly important: isPrototypeOf is also resilient against Symbol.hasInstance shenanigans. The real benefit is needing less imports to perform brand checks now that it is unified.