Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make fetch test independent from internet connection #3691

Merged
merged 1 commit into from
Oct 7, 2024
Merged

test: make fetch test independent from internet connection #3691

merged 1 commit into from
Oct 7, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 6, 2024

missed this test when wanting to make test run without internet

@Uzlopak Uzlopak requested a review from ronag October 6, 2024 16:49
mcollina
mcollina approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 36557bb into main Oct 7, 2024
38 checks passed
flakey5 pushed a commit to flakey5/undici that referenced this pull request Oct 8, 2024
@Uzlopak @flakey5
test: make fetch test independent from internet connection (nodejs#3691)
a158423
@Uzlopak Uzlopak deleted the make-test-independent-from-inet branch October 10, 2024 13:03
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina