Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsdoc: adds some jsdoc to fetch headers implementation, minor changes #3687

Merged
merged 1 commit into from
Oct 5, 2024
Merged

jsdoc: adds some jsdoc to fetch headers implementation, minor changes #3687

merged 1 commit into from
Oct 5, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Oct 5, 2024

No description provided.

@Uzlopak Uzlopak requested a review from KhafraDev October 5, 2024 15:24
KhafraDev
KhafraDev reviewed Oct 5, 2024
View reviewed changes
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any benefit.

mcollina
mcollina approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Uzlopak Uzlopak merged commit bba6f1a into main Oct 5, 2024
38 checks passed
@Uzlopak Uzlopak deleted the jsdoc-headers branch October 5, 2024 20:56
flakey5 pushed a commit to flakey5/undici that referenced this pull request Oct 8, 2024
@Uzlopak @flakey5
jsdoc: adds some jsdoc to fetch headers implementation, minor changes (…
be9b5ee 
…nodejs#3687)
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @KhafraDev