feat: check maxHeadersSize on client instantiation and not on Parser instantion #3654
Conversation
There was a problem hiding this comment.
Adding the extra step of validation on dispatcher/client lgmt, but I believe the issue will prevail.
The problem roots to the defaults. If no maxHeaderSize passed and if the runtime doesn't populate [(node:http).maxHeaderSize](https://nodejs.org/api/http.html#httpmaxheadersize), there won't be value to check against it.
I believe the check on client-h1 aimed to avoid that exact scenario.
|
Yeah, I guess we can consider this an improvement and not a fix. Unfortunately i can somehow not remove the link to that issue. If you approve I would merge it and then reopen the linked issue. |
Uzlopak
changed the title
|
I still think that we dont need that check in the parser. Also why should the parser check if the attribute on the client is valid? Actually hints it to be a validation, that has to happen in the Client API. But you are right, we need to be stricter. PTAL |
|
Or wait... hmm, wont it mean, that you can set maxHeaderSize to 0 meaning any header size? |
|
Just tests seems not happy |
|
Tests should now be happy. :D Also I think that the check in parser is not necessary anymore, because it is handled properly in client already. |
…instantion (nodejs#3654) * fix: check maxHeadersSize on client instantiation and not on Parser instantion * ensure that http.maxHeadersize is valid * fail early, fail fast * fix --------- Co-authored-by: Carlos Fuentes <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3654-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01abc4fc601edba0f5ec7d2cb2388e50e006d3cd
# Push it to GitHub
git push --set-upstream origin backport-3654-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.xThen, create a pull request where the |
I guess this would fix 3652 .I am less inclined to download NW.js and figure out how it works. Imho validation of maxHeadersSize should not be done in Parser construction but in the client instantiation.