Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various typos #3640

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix: various typos #3640

merged 3 commits into from
Sep 30, 2024

Conversation

NathanBaulch
Copy link
Contributor

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • contructor (3)
  • occured (2)
  • reuest (2)
  • shoudl (1)
  • afterwords (1)
  • availabile (1)
  • concatanete (1)
  • existant (1)
  • isable (1)
  • statu (1)
  • undinci (1)

szepeviktor
szepeviktor reviewed Sep 23, 2024
View reviewed changes
docs/docs/api/MockPool.md
A `MockScope` is associated with a single `MockInterceptor`. With this, we can configure the default behaviour of a intercepted reply.
A `MockScope` is associated with a single `MockInterceptor`. With this, we can configure the default behaviour of an intercepted reply.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanBaulch I also do random PR-s with typos.
How do you spot wrong indefinite articles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IntelliJ highlights them. I usually only fix them if the PR I'm working on isn't getting too out of hand.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.jetbrains.com/help/idea/grammar.html

@NathanBaulch NathanBaulch mentioned this pull request Sep 23, 2024
Merged
KhafraDev
KhafraDev previously requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes to lib/web should be reverted.

lib/web/fetch/body.js Outdated Show resolved Hide resolved
lib/web/fetch/body.js Outdated Show resolved Hide resolved
lib/web/fetch/body.js Outdated Show resolved Hide resolved
lib/web/fetch/data-url.js Outdated Show resolved Hide resolved
lib/web/fetch/data-url.js Outdated Show resolved Hide resolved
lib/web/fetch/response.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/util.js Outdated Show resolved Hide resolved
lib/web/fetch/webidl.js Outdated Show resolved Hide resolved
lib/web/fetch/webidl.js Outdated Show resolved Hide resolved
@NathanBaulch
Copy link
Contributor Author

Is lib/web an upstream package @KhafraDev?

@KhafraDev
Copy link
Member

The comments come from the various whatwg specs we implement.

metcoder95
metcoder95 reviewed Sep 24, 2024
View reviewed changes
lib/llhttp/constants.js Outdated Show resolved Hide resolved
@Uzlopak Uzlopak dismissed KhafraDev’s stale review September 30, 2024 22:31

requested changes were applied

@Uzlopak Uzlopak changed the title Fix typos fix: various typos Sep 30, 2024
Uzlopak
Uzlopak approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 29473db into nodejs:main Sep 30, 2024
32 checks passed
@NathanBaulch NathanBaulch deleted the typos branch September 30, 2024 23:26
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szepeviktor szepeviktor szepeviktor left review comments

@metcoder95 metcoder95 metcoder95 approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@KhafraDev KhafraDev KhafraDev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NathanBaulch @KhafraDev @szepeviktor @Uzlopak @metcoder95