Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch: avoid async function in mainFetch to generate response #3605

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fetch: avoid async function in mainFetch to generate response #3605

merged 1 commit into from
Sep 19, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 13, 2024

We can avoid some promises here.

@Uzlopak Uzlopak requested a review from KhafraDev September 13, 2024 21:58
mcollina
mcollina approved these changes Sep 14, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@KhafraDev could you take a look?

@mcollina mcollina merged commit c153875 into main Sep 19, 2024
38 checks passed
@Uzlopak Uzlopak deleted the main-fetch-response-creation branch September 19, 2024 13:37
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina