Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostics-channel: use not deprecated subscribe fn #3600

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 13, 2024

In engines we declare that we support node >= 18.17. and the new subscribe notation is existitng since 18.7.

https://nodejs.org/api/diagnostics_channel.html#diagnostics_channelsubscribename-onmessage

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c773728 into main Sep 13, 2024
38 checks passed
@Uzlopak Uzlopak deleted the diagnostics-channel-new-format branch September 13, 2024 14:45
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants