Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: husky deprecation warning #3593

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: husky deprecation warning #3593

merged 1 commit into from
Sep 13, 2024

Conversation

eXhumer
Copy link
Contributor

@eXhumer eXhumer commented Sep 12, 2024

This relates to...

Fixes #3592

Rationale

husky made changes on how it is used on v9. See https://github.com/typicode/husky/releases/tag/v9.0.1 for more information.

Changes

  • fix husky deprecation warning

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

  • fix husky deprecation warning

Status

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I actually dont know, why we have husky AND pre-commit

@Uzlopak Uzlopak merged commit 54e1fef into nodejs:main Sep 13, 2024
32 checks passed
@eXhumer eXhumer deleted the fix-husky branch September 13, 2024 00:18
@eXhumer
Copy link
Contributor Author

eXhumer commented Sep 13, 2024

I actually dont know, why we have husky AND pre-commit

pre-commit was added with initial commit (25b8a54), pre-commit usage seems to have been replaced with husky with #605. Should be safe to remove as dev dependency.

@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

husky deprecation warning when trying to add a commit
2 participants