Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve jsdoc of lib/core/constants.js #3570

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 9, 2024

image

@tsctx
Copy link
Member

tsctx commented Sep 9, 2024

Strict typings aren't required as only tree construction is used.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 9, 2024

@tsctx

Wasnt there an issue, where we target to generate the typings from the jsdoc documentation? For that these changes are created.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 9, 2024

@tsctx
#3132 (comment)

@Uzlopak Uzlopak merged commit 0b48868 into main Sep 10, 2024
38 checks passed
@Uzlopak Uzlopak deleted the lib-core-constants branch September 10, 2024 10:31
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants