fix: use fasttimers for all connection timeouts

[Uzlopak]

Fixes #3410
Fixes #3553

currently WIP!

Assessment:

The PR #3495 was imho the right step to fix the event loop issues. But Connection issues were still reported. Maybe the issue still existing because timeouts smaller than 1000ms will be handled by native Timers. Maybe those have to handled by the low resolution fast timer logic too, so that event loop blockers are less effecting the processing of requests.

Maybe we should increase the resolution of the timers to 200ms?! It should be still more performant than having a gazillion of native timers?

Maybe we should change this else if to an if and maybe check if the timer missed a tick (with the side effect that we need to call performance.now()).

undici/lib/util/timers.js

Line 159 in 89a46dd

} else if (

So if we skipped a tick, we immediatly run the timer, because we are just too late?

But on the other hand, this could actually trigger timeouts too early?!

So yeah, I would prefer to increase the resolution.

[KhafraDev]

Are the fast timers even needed anymore after nodejs/node#46579?

[ronag]

Yea. I don't think that PR (nodejs/node#46579) makes much difference.

[ronag]

Are the fast timers even needed anymore after nodejs/node#46579?

Fast timers also adjust for event loop lag.

[Uzlopak]

Ok, then i change this PR to rip out fast timers

[ronag]

Do not remove fast timers. That's the opposite of what I was trying to say.

[Uzlopak]

@ronag

Oh! good that i had a backup :). reverted

[Uzlopak]

@ronag

but one thing maybe for interest

The test run for ripped out fast timers passes the tests

https://github.com/nodejs/undici/actions/runs/10714949877

This indicates that event loop lags are also handled properly by native timers.

But I guess we want to keep our fast timers solution due to the fact, that it is still less resource hungry.

[ronag]

This indicates that event loop lags are also handled properly by native timers.

IMO This shouldn't be true as it's based on the uv loop... to me it more indicates an issue with our test

[Uzlopak]

let me fix the request-timeout tests.

[Uzlopak]

@ronag

Should we also use setFastTimeout here?

undici/lib/core/connect.js

Line 169 in 61a4b69

const timer = timers.setTimeout(() => {

[ronag]

Yes

[Uzlopak]

adapted so far, but not all tests are reactivated. so please not merge yet

[Uzlopak]

@ronag

Because you asked, why i change the port. The thing is, that I want to use the port for the connection timeout to have in the logs the chance to determine atleast which server/connection resulted in a connection timeout.

[github-actions]

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3552-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dca0aa0998cbdef28916b23d6300beb2fd979140
# Push it to GitHub
git push --set-upstream origin backport-3552-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3552-to-v6.x.

[trivikr]

The backport fails to 6.x, as the refactor of fast timers in #3495 is not backported to 6.x

[github-actions]

The backport to v6.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3552-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dca0aa0998cbdef28916b23d6300beb2fd979140
# Push it to GitHub
git push --set-upstream origin backport-3552-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x

Then, create a pull request where the base branch is v6.x and the compare/head branch is backport-3552-to-v6.x.