fix: reduce memory usage in client-h1 #3510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #2143 ?
tbh... I investigated the heap and saw alot of Timeouts (of our fast timers implementation) dangling(?) with onParserTimeout as callback. I guess when you run it for 6 minutes, like in the reproduction of the reported issue, some of those timeouts keep dangling and get not gc'ed?
Anyhow... this PR seems to reduce the memory usage anyway?!
So please review/take it with a grain of salt.
before:
after: