-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DNS interceptor #3490
Conversation
It is on a super early state, but should be ok to review @ronag
|
I'm super busy this month. Will do my best to provide feedback. But for now I mostly have time for high level feedback. LGTM so far. |
We can improve the caching with a self made LRU if we want, but I'd rather explore that in further PRs |
I'll be fixing the tests down the path; hopefully the Windows one are easier to fix |
570702c
to
9b01a09
Compare
CI does not seem happy |
I'm intrigued about the Ubuntu ones, but the Window's ones seem odd. I'll check them throughout the week |
e7a4a55
to
c721865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
are we good to merge? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3490-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bebe53c396e55dceda23109277ef578a90e3b27e
# Push it to GitHub
git push --set-upstream origin backport-3490-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.x Then, create a pull request where the |
Closes #3350
WIP