Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't call onConnect automatically #3407

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix: don't call onConnect automatically #3407

merged 1 commit into from
Jul 17, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 17, 2024

In some edge cases this causes issues. Leave it to the user to handle if necessary.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@ronag
fix: don't call onConnect automatically
9e4cc3e 
In some edge cases this causes issues. Leave it to the user to
handle if necessary.
metcoder95
metcoder95 reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like which scenarios?

@ronag
Copy link
Member Author

ronag commented Jul 17, 2024

I actually don't quite remember. I think it was related to an error case in redirect handler.

metcoder95
metcoder95 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let me know if you can remember the scenario, so we can add a test for it later on

@ronag ronag added the semver-major Features or fixes that will be included in the next semver major release label Jul 17, 2024
@ronag ronag merged commit c1f7d2a into main Jul 17, 2024
36 checks passed
@Uzlopak Uzlopak deleted the onconnect branch August 1, 2024 09:57
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees
No one assigned
Labels
semver-major Features or fixes that will be included in the next semver major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronag @metcoder95