-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add query parameter to benchmark #1676
Conversation
Codecov ReportBase: 94.74% // Head: 95.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
+ Coverage 94.74% 95.47% +0.72%
==========================================
Files 53 39 -14
Lines 4892 2828 -2064
==========================================
- Hits 4635 2700 -1935
+ Misses 257 128 -129
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Not sure this is very indicative for the most common use cases... |
Thank you for the comment @ronag. This is the worst-case scenario, since |
Here are the benchmark inputs from the Node repository: https://github.com/nodejs/node/blob/main/benchmark/querystring/querystring-stringify.js#L11 |
I think we should optimize for most common case rather than worst case. I'm not sure what that is but I'm pretty sure e.g. BigInt is quite unusual... |
That seems reasonable. I'll remove it, and update the pull-request. |
1b3340d
to
e994ebf
Compare
Referencing #1673, this pull request adds
query
as a parameter to benchmarks.