Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: balanced pool #1114

Merged
merged 3 commits into from
Nov 27, 2021
Merged

fix: balanced pool #1114

merged 3 commits into from
Nov 27, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 27, 2021

Unified pool and balanced-pool to use the same scheduling implementation. There is still room for improvement but this is a good first step.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2021

Codecov Report

Merging #1114 (615c7c1) into main (caf9ec3) will decrease coverage by 0.12%.
The diff coverage is 99.30%.

❗ Current head 615c7c1 differs from pull request most recent head 205b58b. Consider uploading reports for the commit 205b58b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   94.40%   94.27%   -0.13%     
==========================================
  Files          39       40       +1     
  Lines        3806     3790      -16     
==========================================
- Hits         3593     3573      -20     
- Misses        213      217       +4     
Impacted Files Coverage Δ
lib/balanced-pool.js 97.05% <95.45%> (+0.63%) ⬆️
lib/pool-base.js 100.00% <100.00%> (ø)
lib/pool.js 100.00% <100.00%> (ø)
lib/core/errors.js 94.62% <0.00%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf9ec3...205b58b. Read the comment docs.

@ronag ronag force-pushed the balanced-pool branch 2 times, most recently from 53689f5 to 615c7c1 Compare November 27, 2021 19:53
@ronag ronag requested a review from mcollina November 27, 2021 19:54
@ronag ronag marked this pull request as ready for review November 27, 2021 19:54
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 2d67e31 into main Nov 27, 2021
ronag added a commit that referenced this pull request Nov 27, 2021
* fix: balanced pool

* fixup

* fixup
ronag added a commit that referenced this pull request Nov 27, 2021
* fix: balanced pool

* fixup

* fixup
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* fix: balanced pool

* fixup

* fixup
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* fix: balanced pool

* fixup

* fixup
@Uzlopak Uzlopak deleted the balanced-pool branch February 21, 2024 12:37
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix: balanced pool

* fixup

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants