Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2 onHeaders calls with header object instead of array #3023

Closed
ronag opened this issue Mar 31, 2024 · 7 comments · Fixed by #3025
Closed

http2 onHeaders calls with header object instead of array #3023

ronag opened this issue Mar 31, 2024 · 7 comments · Fixed by #3025
Assignees
@metcoder95
Labels
bug Something isn't working

Comments

@ronag
Copy link
Member

ronag commented Mar 31, 2024

onHeaders should receive a raw headers array, in h2 it doesn't...
@ronag ronag added the bug Something isn't working label Mar 31, 2024
@ronag
Copy link
Member Author

ronag commented Mar 31, 2024

@metcoder95

@metcoder95
Copy link
Member

SGTM 👍

@metcoder95
Copy link
Member

next needs some rebase to cope with the project structure refactor

@ronag
Copy link
Member Author

ronag commented Mar 31, 2024

Yea I don't know how to handle the next branch. Will discuss with @mcollina next week.

@ronag
Copy link
Member Author

ronag commented Mar 31, 2024

@metcoder95 I would consider this a bug fix and not semver major, h1 will send an array and h2 will send an object atm.

@metcoder95
Copy link
Member

Well, true; but if there are implementations already depending on h2 headers as object, we might break them, although we mark them as experimental so maybe not that bad.

I'll open a PR to main we take it from there 👍

@mcollina
Copy link
Member

h2 is experimental.

metcoder95 added a commit that referenced this issue Mar 31, 2024
@metcoder95
refactor(#3023): Pass headers as array instead
2b1ffab
@metcoder95 metcoder95 mentioned this issue Mar 31, 2024
Merged
7 tasks
mcollina pushed a commit that referenced this issue Apr 1, 2024
@metcoder95
refactor(#3023): Pass headers as array instead (#3025)
d7f10e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metcoder95 metcoder95

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(#3023): Pass headers as array instead nodejs/undici
3 participants
@mcollina @ronag @metcoder95