Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node core triage team #414

Merged
merged 7 commits into from
Jan 1, 2019
Merged

update node core triage team #414

merged 7 commits into from
Jan 1, 2019

Conversation

vdeturckheim
Copy link
Member

The people on this list are the ones who have access to the Core HackerOne program.

@bnoordhuis and @shigeki I don't see you in the HackerOne team, is this a miss?

@vdeturckheim vdeturckheim mentioned this pull request Oct 10, 2018
Closed
3 tasks
@vdeturckheim
Copy link
Member Author

cc @nodejs/security-triage

@lirantal lirantal added the DOCS label Oct 10, 2018
lirantal
lirantal approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell reviewed Oct 11, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice, I think, to use the same emeritus pattern here that we use elsewhere, rather than just removing folks.
Also, I've also pulled back from initial triage... So perhaps a section:

### Emeritus

- @bnoordhuis
- @jasnell
- @shigeki

thefourtheye
thefourtheye reviewed Oct 11, 2018
View reviewed changes
processes/security_team_members.md
- @indutny - **Fedor Indutny**
- @rvagg - **Rod Vagg**
- @jasnell - **James M Snell**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell Is nodejs/TSC#599 relevant here? Just confirming.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! To be certain, I'm just stepping away from the triage bit.

@vdeturckheim
Copy link
Member Author

Good point @jasnell updating

mhdawson
mhdawson reviewed Oct 16, 2018
View reviewed changes
processes/security_team_members.md
- @indutny - **Fedor Indutny**
- @jasnell - **James M Snell**
- @mcollina - **Matteo Colina**
- @mhdawson - **Michael Dawson**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need another list. I have access to HackerOne so that I can help with security release planning/mechanics but I don't actively triage new entries...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just you it's probably ok to keep the current list as is instead of creating new lists (might cause confusion and noise).

@lirantal
Copy link
Member

lirantal commented Nov 1, 2018

@vdeturckheim mergable?

mcollina
mcollina approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Nov 1, 2018 •
edited
Loading

@bnoordhuis I have seen you have been more active lately. Should you remain on the list of triagers or does it make sense to move to emeritus?

@lirantal
Copy link
Member

LGTM
@vdeturckheim unless you (or others) want to make any further changes, I'll go ahead and merge in a couple of days.

@lirantal lirantal mentioned this pull request Dec 29, 2018
Closed
@lirantal lirantal merged commit 92a2b78 into nodejs:master Jan 1, 2019
waveywaves pushed a commit to waveywaves/security-wg that referenced this pull request Jan 7, 2019
@vdeturckheim @waveywaves
docs(team): update node core triage team (nodejs#414)
9453235
@sam-github sam-github mentioned this pull request Jul 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@thefourtheye thefourtheye thefourtheye left review comments

@jasnell jasnell jasnell left review comments

@lirantal lirantal lirantal approved these changes

@mcollina mcollina mcollina approved these changes

Assignees

@vdeturckheim vdeturckheim

Labels
DOCS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vdeturckheim @lirantal @mhdawson @mcollina @jasnell @thefourtheye