fix: bump remark-lint-prohibited-strings from 1.5.1 to 1.5.2 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that causes remark-preset-lint-node to miss some errors. Refs: nodejs/node#33691
3 tasks
|
Upstream fix for tests: nodejs/node#33719 |
richardlau
approved these changes
Jun 4, 2020
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 4, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <[email protected]> PR-URL: nodejs#33719 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 18, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <[email protected]> PR-URL: #33719 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 30, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <[email protected]> PR-URL: #33719 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 9, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <[email protected]> PR-URL: #33719 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 14, 2020
Disable linting for prohibited strings in the collaborator list so that sam-github does not have to be sam-GitHub. Refs: nodejs/remark-preset-lint-node#96 Signed-off-by: Rich Trott <[email protected]> PR-URL: #33719 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that causes remark-preset-lint-node to miss some
errors.
Refs: nodejs/node#33691