Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add static builds to ci to ensure static builds are still working #5617

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Aug 9, 2023

Description

This PR simply adds static builds in addition of our regular minimal buids, to ensure that all pages are building correctly at build time and that static builds still work regardless of the changes we're doing

Validation

The current PR checks should pass

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 8:20pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.21% (367/398) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 8.347s ⏱️

@ovflowd
Copy link
Member Author

ovflowd commented Aug 9, 2023

Failing on Windows due to: vercel/next.js#51225

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ovflowd ovflowd added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 1fbd908 Aug 10, 2023
@ovflowd ovflowd deleted the chore/add-static-builds-to-ci branch August 10, 2023 20:37
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Aug 10, 2023
This normalizes the backslash for windows users who accidentally use `\` in the request paths instead of the expected `/`.

For example, in nodejs/nodejs.org#5617 the slash was hardcoded for split that caused the backlash to remain the the `getStaticPaths()` result.

- Fixes #51225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants