chore: dedicated step for build and analysis #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
cc @website as I need an urgent fast track over here. |
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the current structure of the
pull-request.ymlGitHub Actions Workflow by creating a dedicated Workflow for Build & Analysis.This allows us to do builds on
mainand any Pull Request. This also fixes the issue that the Bundle Analysis are never happening onmain, causing the bundle analysis to be ineffective.