chore: use defined urls for distribution and api docs #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
added
fast-track
|
Requesting Fast-Tracking cc @nodejs/website |
HinataKah0
approved these changes
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 10, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 12, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 12, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 12, 2023
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Environment-defined constants that can be used to define custom URLs that should be used for the Node.js Distribution CDN (nodejs.org/dist) and Node.js API Docs URL (nodejs.org/docs).
Note that these changes only affect JavaScript and TypeScript files, not any Markdown pages. Which is fine as in the future, these pages will get replaced.
Also, these environment variables should at best be used for testing.
Related Issues
Relates to nodejs/build#3366