Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove github pages #5468

Merged
merged 1 commit into from
Jul 2, 2023
Merged

chore: remove github pages #5468

merged 1 commit into from
Jul 2, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 2, 2023

This PR simply removes the support to GitHub Pages, as we use Vercel Deployments now (Previews and "Production" builds) and there seems to be no reason, to use extra CI on the main branch for GitHub Pages.

@ovflowd ovflowd requested a review from a team as a code owner July 2, 2023 19:22
@vercel
Copy link

vercel bot commented Jul 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2023 7:31pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2023 7:31pm

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 2, 2023 19:22 Inactive
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jul 2, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 2, 2023 19:24 Inactive
@ovflowd
Copy link
Member Author

ovflowd commented Jul 2, 2023

cc @nodejs/website if anyone has an opinion here. And requesting fast-tracking of this, as this seems like a no-brainer IMHO.

@bmuenzenmeyer
Copy link
Collaborator

LGTM - aside from the public/ thrashing which IIRC we are fixing elsewhere

@ovflowd
Copy link
Member Author

ovflowd commented Jul 2, 2023

aside from the public/ thrashing which IIRC we are fixing elsewhere

Oh these files got committed T.T

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 2, 2023 19:30 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 2, 2023 19:31 Inactive
Copy link
Contributor

@Harkunwar Harkunwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd ovflowd merged commit 115d2e7 into nodejs:main Jul 2, 2023
@ovflowd ovflowd deleted the chore/remove-github-pages branch July 2, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants