-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update process to become a collaborator #5441
Conversation
Signed-off-by: Claudio Wunder <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Claudio Wunder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for clarifying
I found some other things we should fix in future PRs
Signed-off-by: Claudio Wunder <[email protected]>
I've updated and reformatted the file |
@bmuenzenmeyer and @HinataKah0 if you could update your suggestions/review based on my latest changes as I don't know if they're still relevant. |
Satisfied with the changes in the table of contents / structure 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good!
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Claudio Wunder <[email protected]>
cc @nodejs/website as we need more approvals here :) |
Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Claudio Wunder <[email protected]>
I'm merging this as we got enough approvals. Thank you all! |
In order to make the process of becoming a collaborator more streamlined (and similar to the process of Node.js Core) this Pull Request makes changes to the Contributing Guidelines (and the Website Team chart) by changing how contributors might or might not become Collaborators.
cc @nodejs/website
Closes #5440