Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(api changes) #5417

Merged
merged 9 commits into from
Jun 11, 2023
Merged

Feat(api changes) #5417

merged 9 commits into from
Jun 11, 2023

Conversation

vasanth9
Copy link
Contributor

@vasanth9 vasanth9 commented Jun 2, 2023

Description

Migrating the ApiChanges component from nodejs.dev

Related Issues

Related #5309
new pull request to main branch , same as closed PR #5351

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@vasanth9 vasanth9 requested a review from a team as a code owner June 2, 2023 11:51
@vercel
Copy link

vercel bot commented Jun 2, 2023

Someone is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2023 1:56pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview Jun 11, 2023 1:56pm

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 2, 2023 11:52 Inactive
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 3, 2023 02:40 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 7, 2023 11:23 Inactive
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thank you for your contribution! I think there's just one small thing to be adjusted here as I see that just two CSS rules are missing. 🤔

image

(Screenshot is from nodejs.dev)

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 8, 2023 02:48 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org June 8, 2023 02:49 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 10, 2023 15:40 Inactive
@vasanth9
Copy link
Contributor Author

Good stuff! Thank you for your contribution! I think there's just one small thing to be adjusted here as I see that just two CSS rules are missing. thinking
image

(Screenshot is from nodejs.dev)

added

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 10, 2023 16:59 Inactive
@ovflowd ovflowd merged commit c731873 into nodejs:main Jun 11, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org June 11, 2023 13:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants