-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Improve the TRANSLATION.md #5232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of TRANSLATION.md for Crowdin is a bit too simple to understand, especially for a newbie who wants to join in the group and how to get started. Here I've given some very useful links to guide them step-by-step on how to cope with Crowdin and join in the translating group together to make contributions to nodejs.org. Several changes: 1. Rename 'Crowdin' to 'Nodejs-website in Crowin', because this is a nodejs-website based Crowdin project. 2. Add more step-by-step guides to bring you to the home of Crowdin and join in it without problems to get started quickly. Signed-off-by: Wai.Tung <[email protected]>
I'm a newbie to bother others about Crowdin, and I don't like others bothering and questioning here and there, that's the reason why I want to improve this article, hope most frequently-asked questions can be solved here :) |
AugustinMauroy
approved these changes
Apr 5, 2023
Trott
reviewed
Apr 5, 2023
fix according to @Trott 's review Signed-off-by: Wai.Tung <[email protected]>
mikeesto
approved these changes
Apr 6, 2023
manishprivet
approved these changes
Apr 6, 2023
ovflowd
reviewed
Apr 6, 2023
Oh, many thanks! This is more suitable. Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Wai.Tung <[email protected]>
ovflowd
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for updating the docs, @MaledongGit!
araujogui
pushed a commit
to araujogui/nodejs.org
that referenced
this pull request
Apr 14, 2023
Co-authored-by: Claudio Wunder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of TRANSLATION.md for Crowdin is a bit too simple to understand, especially for a newbie who wants to join in the group and how to get started. Here I've given some very useful links to guide them step-by-step on how to cope with Crowdin and join in the translating group together to make contributions to nodejs.org.
Several changes:
Rename 'Crowdin' to 'Nodejs-website in Crowin', because this is a nodejs-website based Crowdin project.
Add more step-by-step guides to bring you to the home of Crowdin and join in it without problems to get started quickly.
For any discussions related to our previous discussion at Some Suggestions and Questions on Localizations' changes #5222 (reply in thread) and Some Suggestions and Questions on Localizations' changes #5222 (reply in thread), we'd better include such info to let volunteers get to know how to have discussions/chats in Crowdin instead of in GitHub.