Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header layout on small screen size #5192

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix header layout on small screen size #5192

merged 2 commits into from
Mar 28, 2023

Conversation

rodion-arr
Copy link
Contributor

@rodion-arr rodion-arr commented Mar 27, 2023 •
edited
Loading

Before
image

After
image

Closes #5096

@rodion-arr rodion-arr requested a review from a team as a code owner March 27, 2023 17:03
ovflowd
ovflowd approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Could we also add a margin here? (So the buttons are a lil bit further from the navigation?

shanpriyan
shanpriyan reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Can we add a little bit of top padding to the theme and lang button between the range of 481px and 1000px screen size

@rodion-arr
Copy link
Contributor Author

@ovflowd, @shanpriyan, margin added

@ovflowd
Copy link
Member

ovflowd commented Mar 28, 2023

@rodion-arr could you attach a preview to the latest change? (screenshot). Thank you!

@nodejs/website do y'all mind if I fast-track the PR?

@rodion-arr
Copy link
Contributor Author

image

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Mar 28, 2023
@ovflowd
Copy link
Member

ovflowd commented Mar 28, 2023 •
edited
Loading

Fast-tracking the PR!

cc @nodejs/website

@ovflowd ovflowd merged commit da0361e into nodejs:main Mar 28, 2023
@rodion-arr rodion-arr deleted the header-low-screen-size branch April 2, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanpriyan shanpriyan shanpriyan left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@aymen94 aymen94 aymen94 approved these changes

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

layout gets messed up at some viewport sizes
5 participants
@rodion-arr @ovflowd @aymen94 @shanpriyan @AugustinMauroy